get_info nvt: Don't add solution elements to tags. #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janowagner
force-pushed
the
unified_vt_solution
branch
from
5d484d9
to
b5b9001
Compare
Since the solution and solution_type are now in a element of its own, we do not need them in the tags element of the nvt for the get_info response. This change should be merged after GSA parses the solution and solution_type properly from the new elemnt for the get_info command.
janowagner
force-pushed
the
unified_vt_solution
branch
from
b5b9001
to
d6ecebd
Compare
janowagner
requested review from
mattmundell and
timopollmeier
as code owners
mattmundell
approved these changes
Oct 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the solution and solution_type are now in a element
of its own, we do not need them in the tags element of the nvt
for the get_info response.
This change should be merged after GSA parses the solution and
solution_type properly from the new element for the get_info command.
Checklist: